Problems editing comments while on another member's page

TalkBug Collectors

Join LibraryThing to post.

Problems editing comments while on another member's page

This topic is currently marked as "dormant"—the last message is more than 90 days old. You can revive it by posting a reply.

1LibraryPerilous
Edited: Nov 29, 2014, 3:55 pm

I posted a comment to a member's wall and then tried to fix a typo while still on her wall. The edit showed in preview but the comment reverted to the original, with typo. However ...

1) When I returned to my own wall, the comment appeared on my wall in the edited form. Returning to the member's wall then showed the comment in the new, edited form.

2) I was able to delete the comment from either wall.

3) I was able to edit the comment from my own wall and have it 'take' immediately on both walls.

Is this expected behavior? I've already forgotten how the old comments system worked.

ETA: Win7, FF 33.1

2timspalding
Edited: Dec 3, 2014, 2:18 pm

Given to Ammar.

Expansion:

It appears that if I edit a comment from the person's profile, it

1. Thinks it's a new comment, see https://www.dropbox.com/s/hp2lss7sw35qex2/Screenshot%202014-12-03%2014.16.16.png...
2. It doesn't change it in situ.

To replicate:

1. Leave someone a comment.
2. Go away and do whatever.
3. Go to https://www.librarything.com/comments and edit your comment.
4. That works.
5. Go to their profile.
6. Edit the comment there.
7. That doesn't work. It shows https://www.dropbox.com/s/hp2lss7sw35qex2/Screenshot%202014-12-03%2014.16.16.png...

This is going to be tricky. This is deep code you did not work on. Don't break anything.

3LT_Ammar
Dec 11, 2014, 12:39 pm

So, while the comments look very similar whether in your own wall or another members, there is some code differences behind them.
Basically, when you were in your own wall, a call was being made to refresh the comment. In a similar area for the javascript for when you are in a members wall was missing that call(which existed elsewhere in the same file, just not when you edited).

Anyways, added the refresh call and now we should be on our merry way! :)

4LibraryPerilous
Dec 11, 2014, 12:41 pm

>3 LT_Ammar: Thanks! It's awesome to see these bugs being squashed so rapidly. (Poor things.)

5LT_Ammar
Dec 11, 2014, 4:53 pm

Thank you @diana.n for being so helpful and pointing these out!

6timspalding
Dec 12, 2014, 1:27 pm

Good work on this one, BTW.