Pause to tag combination?

TalkCombiners!

Join LibraryThing to post.

Pause to tag combination?

This topic is currently marked as "dormant"—the last message is more than 90 days old. You can revive it by posting a reply.

1timspalding
Jun 19, 2011, 12:31 pm

Hey. This is a warning. I'm going to be working on tag combination today--trying to fix the bugs that have crept in. It's possible that:

1. I will propose some wrong combinations. Ignore them.
2. Combinations proposed in the next few hours will not stick.

Thanks.

2keristars
Edited: Jun 19, 2011, 12:35 pm

Oh! I'm looking forward to the results! Especially if this means you're fixing the bug where a proposal for A+B shows as "A+B" on the page for Tag A but "B+B" on the page for Tag B. ♥

3timspalding
Jun 19, 2011, 12:42 pm

Yeah. I'm working on it. I may have to take it down and redo the underlying structure.

4lemontwist
Jun 19, 2011, 6:14 pm

Yessssss!!! :-D

5lemontwist
Jun 19, 2011, 8:48 pm

Any update on this?

6timspalding
Jun 19, 2011, 9:40 pm

Step 6 of 12 or something.

7Heather19
Jun 19, 2011, 11:58 pm

Woot woot woot! Yaaaaaayyyy for bug-fixing!
(this also gives me an excuse to slack off on my nightly tag-combination voting spree....)

8europhile
Jun 20, 2011, 2:15 am

that's a relief!

9Heather19
Jun 20, 2011, 9:19 pm

so.... that was yesterday. Are tag-combining things good to go today?

10bonne1978
Edited: Jun 20, 2011, 9:48 pm

Will this also update tags on works that I added to my books in may?

reported here:
www.librarything.com/topic/116142
and here
www.librarything.com/topic/117141

11timspalding
Jun 21, 2011, 1:37 am

No, still working on it.

12lemontwist
Jun 21, 2011, 8:08 am

Is voting OK to do or should we just stop combining? I'm still seeing a decent amount of new proposals coming through.

13timspalding
Jun 21, 2011, 8:57 am

I've fixed the caching problem people were complaining about, but the combination direction bug is still there. I don't know if I'll have to wipe out proposals and votes or not, but that's the risk now.

14eromsted
Edited: Jun 21, 2011, 9:06 am

I echo those above in being glad to see tag combining bugs getting some work. Just as a reminder, here are some other issues.

Separation proposals are double listed on the tag pages. example

Even though tags that differ only in capitalization are auto-combined, they are listed separately for separation. Is proposing separation for each variant necessary? See same example

Separation proposals are not visually distinct from combination proposals on the tag pages. example

Combination proposals made on tag pages of tags that include quotation marks fail. Go to the tag page for "American Science" and try proposing a combination with American Science. (Apparently I don't know how to make a link to a tag page that includes quotation marks.)

Proposals for very long tags are cut off and fail. There is a work-around, but it's still a problem. See report here.

15lemontwist
Edited: Jun 21, 2011, 7:27 pm

>13 timspalding:. I would really rather not have ~1200 of my tag proposals wiped out. Especially considering the last batch of a large number of my proposals got wiped out.

16lemontwist
Jun 21, 2011, 7:31 pm

If having combinations in the queue is a barrier to fixing these bugs, then perhaps temporarily disable combining, because people are still doing it, and then give people X amount of weeks to finish their voting. After that, close things, and then fix the bugs.

17Heather19
Jun 21, 2011, 9:17 pm

*echos lemontwist*

18lemontwist
Jun 27, 2011, 6:42 am

Tim, can you at least give us a time frame on this?

19Heather19
Jul 8, 2011, 12:11 am

13: So..... any idea what needs to be done to wipe that bug out? Any updates?

20timspalding
Jul 8, 2011, 1:15 am

Sorry guys. We're short-manned right now and I'm running around.

There's no particular problem to doing combinations now. But I need to dig into the code and figure out what the bug is.