Search by clicking magnifying glass in header does not work

TalkBug Collectors

Join LibraryThing to post.

Search by clicking magnifying glass in header does not work

This topic is currently marked as "dormant"—the last message is more than 90 days old. You can revive it by posting a reply.

1KingRat
Nov 17, 2010, 10:06 pm

Type in any search phrase in the search field in the header. Click the magnifying glass.

Search results page comes up. No results. No spinny graphic.

Chrome on Windows 7

2DaynaRT
Nov 17, 2010, 10:27 pm

Same thing happens in mobile Safari.

3jjwilson61
Nov 17, 2010, 11:23 pm

Duplicate. See this bug report, http://www.librarything.com/topic/102610

4brightcopy
Edited: Nov 18, 2010, 12:14 am

Which means I should probably reopen it. Done.

5KingRat
Nov 18, 2010, 2:39 am

Not the same bug. This one is that it clears the search field when it jumps into the search page using this method.

6Nicole_VanK
Nov 18, 2010, 3:15 am

Confirming #5. Different bug.

7brightcopy
Edited: Nov 20, 2010, 3:29 am

I wonder if part of it is the invalid HTML:


<body>
<a name="top"></a>

<div id="prenav" style="display: none;"></div>

<div class="topnav_outside" style="position: relative;">

<div class="topnav" >

<table cellpadding="0" cellspacing="0" border="0" width="100%">

<tr valign="bottom">
<td id="mainlogo">

<a href="/home/brightcopy" target="_top">
<img src="/pics/librarything_logo.gif?1606"
width="232" height="49" border="0" id="mainlogo"
alt="LibraryThing">
</a>

</td>
<td class="hebrewleft"> </td>
</tr>

</table>

</a>


Notice that last </a>. It doesn't match up to anything.

Lots of stuff also gets complained about here:
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.librarything.com%2Ftopic%2F10...

Wonder how much of it would clear up if that dangling tag was snipped.

8brightcopy
Nov 20, 2010, 12:55 pm

Well, the behavior seems to be fixed, but I note that unmatched </a> seems to still be there. Probably a good idea to clean it up to avoid other unexpected behavior.

9timspalding
Nov 20, 2010, 1:18 pm

Cleaned. Thanks.

10brightcopy
Nov 22, 2010, 11:39 am

Broken again.

11timspalding
Nov 22, 2010, 12:10 pm

Okay, am I taking crazy pills? I've got IE8 open and it works just fine.

Method:

1. Click on lozenge.
2. Type a word.
3. Click magnifying glass

Arrives on page with word as term.

12brightcopy
Nov 22, 2010, 12:12 pm

11> Yes, you are, but that's besides the point.

I just tried it in IE8 and it failed. Then I saw this and tried it again and it didn't fail.

So apparently I'm on the same Rx. I'll keep messing with it. Either it's a mass hallucination or there's some more complicated repro.

13brightcopy
Nov 22, 2010, 12:16 pm

I still can't get it to do it again. I'm wondering if I was running into caching. Is the way that mini search box built very susceptible to that? I did it from a talk thread page which I had not visited before in IE so it seems less likely.

SqueakyChu, if you're reading this thread - can you try it again?

14SqueakyChu
Edited: Nov 22, 2010, 1:00 pm

It's now working for me in IE8.

I'm not changing the bug status as I don't know if it will continue to work (from past experience).

ETA: Feel free to change the bug status whenever you (or someone else) wants.

15brightcopy
Nov 22, 2010, 1:03 pm

I'm setting it to Needs discussion and will keep monitoring it. If Tim doesn't mark it fixed, I'll eventually close it after it's still working after a few days.

16r.orrison
Nov 22, 2010, 1:08 pm

Has anyone else tried on iPhone Safari? It's failing for me...
1) Enter search term (in lozenge on talk page)
2) tap magnifying glass
3) get search results page with no search term

17DaynaRT
Nov 22, 2010, 1:21 pm

It's working for me in Safari on the iPad.

18r.orrison
Nov 22, 2010, 1:50 pm

Ok, never mind. I just closed the page in Safari and re-opened it and it worked. Probably had the old version in the local cache...

19brightcopy
Nov 22, 2010, 2:37 pm

Tim said:

Okay, here's my guess. It's now working in IE8. It was working before only if you'd hit refresh a bunch of times--that is, I didn't up the version on the JavaScript file, so some people had it cached.

Anyway, if anyone is having a problem with the magnifying glass now, let me know.


So it does sound like it was caching in combination with the version setting. Closing.