CK languages bug fixed, but I need help...

TalkRecommend Site Improvements

Join LibraryThing to post.

CK languages bug fixed, but I need help...

This topic is currently marked as "dormant"—the last message is more than 90 days old. You can revive it by posting a reply.

1timspalding
Jan 23, 2011, 1:06 am

So, I fixed a bug that I had inadvertently introduced when I brought cross-language editing to Common Knowledge for authors yesterday. The bug introduced new languages to CK—mostly numbers. Basically, I was feeding the user number to the language field.

The trick is, I can't correct it by myself. I don't have the language data. No doubt most are English, but surely not all.

Fortunately, I can clump them all together. I've done so under a new language "CK Error."

Here's an example page:
http://www.librarything.com/author/smithjosephfielding-1



You can see all 800-odd edits to this "language" here. (Warning: Slow.)

http://www.librarything.com/commonknowledge/changelog.php?badlanguages=1

I need help moving the data to the right languages. You can see the data poking through onto other sites (see above). To move it, just edit and save.

Sorry about this. The price of moving too quickly.

Any questions?

2rsterling
Jan 23, 2011, 1:26 am

Doing a bit of work on this.

However, canonical names are funky. Sometimes, if you change a canonical name one of the divided authors, it changes it for everyone. Sometimes it doesn't. I'm not really sure what makes the difference here.

Then, annoyingly, when I went in to correct the error in one author, it changed it again on everyone, but not back to what it originally was.
See here:
http://www.librarything.com/author/agnewjohn
The name should be John Agnew. I had tried to change the (1) to John A. Agnew, which then changed all the names on the disambiguation page to that. But then, when I deleted that, it changed them all to Agnew, John A. - which bears no relation to the URL string. I posted a bug report about a similar case earlier, but I thought this might have been fixed with the other bug. Anyway, I mention it, because it might cause problems as people try to restore the lost data.

3timspalding
Jan 23, 2011, 1:31 am

Yes. Canonical names aren't working right here. I'll work on them. Basically, assume they work...

4timspalding
Jan 23, 2011, 1:37 am

Lay off Mr. Agnew for a little while, while I try to repair him... :)

5rsterling
Jan 23, 2011, 1:39 am

Ok. I'm holding off on other canonical names for the moment too.

A question: the CK for the #1 author is just going into lastnamefirstname rather than lastnamefirstname-1. Is that right/how it's supposed to work?

6r.orrison
Jan 23, 2011, 2:13 am

the CK for the #1 author is just going into lastnamefirstname

IMHO it should not. Think of last-name-only pages. The Canonical Name for /author/paige-1 should not be applied to /author/paige

7r.orrison
Jan 23, 2011, 2:17 am

Fixing things doesn't move them, it just copies them -- they still show up on the list even after they've been fixed.

8timspalding
Jan 23, 2011, 3:38 am

Okay, I've half-fixed canonical authors. Basically, it works except that #1 is still the same as the disambiguation guy. I'll work on that tomorrow.

9timspalding
Jan 23, 2011, 3:39 am

Don't worry about entering the data into CK. The worst-case scenario is that it doesn't show up now. But it will.

10Nicole_VanK
Jan 23, 2011, 5:30 am

Okay, doing some work on these. But is there a way to move them off the list once they're done? All of us visiting the same pages in order to fix the same things - only to find out that somebody else already did that one - will get frustrating.

11guurtjesboekenkast
Edited: Jan 23, 2011, 7:04 am

http://www.librarything.nl/author/lambert

I've done some work on this writer and I think you have to go to each writer separate to fill in the official name but not the full used name, because that will change the name of the writer. So only fill in Lambert, for the used name

Also it only says 'Engels (1) — 49 meer', when I click on '49 meer' it dissapears and when I click on 'Engels', I get Nederlands (3) Engels (1) — 48 meer.

Edited to add the last sentence.

12rsterling
Jan 23, 2011, 11:03 am

10 - Maybe we can delete them from the "error" language once we've copied them over?

13timspalding
Jan 23, 2011, 4:43 pm

I think you can delete them off the "error" page.

Will look into bug in 11. Much to do. Much to do.

14rsterling
Jan 23, 2011, 4:44 pm

Tim, I've just realized that there's a limit to how many entries that CK history page will display. I've been deleting data from the "CK error" site once I put it in the right language site, but on the CK history, that just pushes everything down, presumably pushing some things that need to be fixed off the page. Is there any way to see more on the page, or see multiple pages?

15timspalding
Jan 23, 2011, 11:34 pm

Which CK history. The special page I gave in #1 shouldn't be limited. Was it?

16rsterling
Edited: Jan 23, 2011, 11:40 pm

Well, it seems like when I delete something and it adds an entry at the top, something drops off the bottom. (ETA: Yes, the link you gave in #1)

Let me check...

Yeah, it is limited.

A minute ago, the last entry at the bottom was:

Yesterday: 11:21:40 am browneric2 short biography errr Eric Melrose Brown or Capt. E. &… profile catalog masterdeski

I deleted something from the "CK error" site on a completely different author, and it pushed that 11:21:40am entry off the page. It's not there any more.

17miniwark
Jan 24, 2011, 5:54 am

Just one question about the "CK Error" language.

The two strings with "CK error" are available for translation. Actualy i have traslated as is for the french translation (to be more clear i have keep them in english) because i assume than is a temporary language and because i feel the "CK error" is more explicit than the translated "Erreur PC" .

I feel than maybe the 'CK Error' langage string could be more explicit, like with a help link to here or to a dedicated wikithing page.

18guurtjesboekenkast
Jan 25, 2011, 6:55 am

This message has been deleted by its author.

19timspalding
Jan 26, 2011, 11:29 am

I'm going to get rid of all CK Error edits in 24 hours. Any objections?

20rsterling
Edited: Jan 26, 2011, 11:47 am

Argh. I've been working through these, but it takes some time. Have they all been moved over?

PS I'm still having the problem of things dropping off the history list when I delete things from CK error.

Also, last night I was finding that the CK error part of the work page was showing all the English CK data, not only what had been entered on the CK error site, so it was difficult to figure out what needed to be moved where (since the English or French or whatever page doesn't show the localized message if there's already something in the field, even if it's not the same thing.)

21jjwilson61
Jan 26, 2011, 2:00 pm

It looks to me like there are still things on that list, however I don't understand what Tim is saying in post #13. What is the "error page" and how do you delete items off it.

22sqdancer
Jan 26, 2011, 2:30 pm

This message has been deleted by its author.

23rsterling
Jan 26, 2011, 7:42 pm

21 - When you're looking at the CK for an author that has these entries in CK Error, look at the language selection at the top of CK and click on "CK error."

24jjwilson61
Edited: Jan 26, 2011, 8:21 pm

OK, the CK Error "language" page is what he meant. In that case that's what I've been doing but as you pointed out that ends up putting a "deleted previous contents" entry into the page that's linked to from the first post. Did you ever determine if that ended up pushing entries off the bottom?

ETA: And you can't delete the Gender information.

25rsterling
Jan 26, 2011, 9:34 pm

Yeah, it does push things off, but I figured out a trick. I can force it to do a 2nd page:

http://www.librarything.com/commonknowledge/changelog.php?badlanguages=1&sta...

Also, you can delete the gender information. Just open it up, don't click anything, and then save. It will then come up as undefined, and the next time you click on the page it will be empty.

There have been a few cases where I've tried to delete data but it hasn't deleted (in a nationality field), so there may be some buggy things here and there, but if he's going to delete everything anyway, that shouldn't matter.

26jjwilson61
Jan 27, 2011, 1:32 am

Also, you can delete the gender information. Just open it up, don't click anything, and then save. It will then come up as undefined, and the next time you click on the page it will be empty.

Yeah, I found that out, but I could swear it wasn't working that way yesterday. It also leaves "unassigned" in the field which may or may not be the same as not being set at all.

27rsterling
Edited: Jan 27, 2011, 1:42 am

I've been working on this for 3 hours tonight, and a couple yesterday, and frankly, it's too big of a job. If Tim wants to delete all the info, fine, but it will be gone. To actually get people to move the data over would take a few days.

ETA - At least I caught up with bottom of the first page of stuff, though.

28timspalding
Jan 27, 2011, 1:57 am

Yipes. Sorry.

It seemed pretty simple to me. It's a lot of clicks, basically, or are you trying to figure out which language ambiguous data belongs in?

29rsterling
Jan 27, 2011, 2:01 am

Trying to figure it out a bit, but usually just putting it in English. Still, a lot of clicks takes a lot of time.

Also, as I mentioned above, the fact that English CK is showing up in CK Error as if it was entered there makes it difficult and slower to figure out what changes in CK Error need to be copied over, particularly when there's already data in the field in English.

30rsterling
Jan 27, 2011, 2:06 am

You know, maybe just a few more hours would do it, since I think what's left might be around what I did tonight, or maybe even less. I think I'm going to call it quits for the evening.

It's also slower since I've been trying to delete things from CK, so it's easier to see what's been done already, and what hasn't.

31rsterling
Jan 27, 2011, 2:19 am

Ok, by rough count of the CK history I did a bit over 200 tonight, and there's a bit over 300 left. That doesn't take account of fields that had more than one line, since only the first line shows up in CK history.

32rsterling
Jan 29, 2011, 6:47 pm

Anyone want to take some of these on? I know a few people have helped out, but there's still more to do. I'm swamped with work, so I don't think I'll be able to do much more.

33rsterling
Jan 30, 2011, 11:46 am

By the way, here's the 2nd page, since some of the entries get pushed off the first page. (It overlaps a bit with the first, since I'm not sure exactly how many the first is displaying.)
http://www.librarything.com/commonknowledge/changelog.php?badlanguages=1&sta...

I recommend working from the bottom up, so as to eventually get everything that needs editing back on one page.

34rsterling
Feb 5, 2011, 1:20 pm

I think it's all gone from "CK Error" and moved over to proper languages now. Thanks, geitebukkeskjegg, r.orrison, and jjwilson61!