talk subject is not properly escaped when containing quotes as "foobar" trailer

TalkBug Collectors

Join LibraryThing to post.

talk subject is not properly escaped when containing quotes as "foobar" trailer

This topic is currently marked as "dormant"—the last message is more than 90 days old. You can revive it by posting a reply.

1gangleri
Edited: Mar 29, 2012, 4:25 pm

Hi! Please make your own testcase (in a suitable test group - which one?).
a) use "foobar " somewhere at the end in the subject
b) save the message
c) with the first edit of section "0" you will see a field where you can change the talks subject and which is not available in normal talks
for this thread I will see:
talk subject is not properly escaped when containing quotes as \

note: As I remember it may happen also when appending new messages to the thread.

Please confirm! Thanks in advance!

P.S. added \ via \ to
for this thread I will see:
talk subject is not properly escaped when containing quotes as \
P.P.S. 2012-03-29 added
☛ "MetaCharacter"S ?searchtype=talk&search=MetaCharacter

2lorax
Mar 22, 2012, 9:28 am

So you're saying that this is a problem that occurs only when editing subject lines (which you can only do for the first five or ten minutes after posting a topic) when the subject contains a quotation mark (")? That's really a corner case, I think.

3gangleri
Edited: Mar 22, 2012, 9:41 am

>2 lorax: I could see this the first time yesterday. The problem is that the subject for some posts are garbage ... This should not happen to newbies. Maybe it is a simple fix. It is safer anyway.

4brianst
Mar 22, 2012, 12:33 pm

I tweaked the way we were escaping the quotes when they are presented in the edit window. Should be fixed now
Thanks!

5gangleri
Mar 22, 2012, 12:38 pm

Thanks a lot!

6gangleri
Edited: Mar 23, 2012, 10:38 am

>4 brianst: Please see /topic/134672 "Title ending with a REVERSE SOLIDUS - testcase002 -

"\" is another meta character in LT and in many places.

main question:: How that (the meta character "\") can be entered as a valid character to be displayed in talk titles?
other question? Why is the original poster not allowed to change the thread title (after some feedback was added eaven by himself)?

Note1) \ is used here to document the character \

7gangleri
Edited: Mar 23, 2012, 11:08 am

/topic/134678 "inkify authors, books series etc. at /talk = Your books - Your authors = Topics about your books and authors"

This topic is about the usage of ">" in title names. ("<" is probably similar)

Note1) &gt; is used here to document the character >
and &lt; is used here to document the character <

8jjwilson61
Mar 23, 2012, 10:12 pm

Why is the original poster not allowed to change the thread title

You can within 10 minutes of creating the thread. After that you can't because changing it after people might have posted to the thread already could lead to some dirty tricks. Imagine someone creating a thread called "Post here if you like ice cream" and then changing it to "Post here if you like to be spanked"!

9gangleri
Mar 24, 2012, 1:23 am

>8 jjwilson61: Thanks! A good reason.

10gangleri
Mar 27, 2012, 8:26 am

>8 jjwilson61:

I found some good reasons where you want to change topic titles.
a) If topic titles are badly corrupted in their significance. example /topic/134562#3304009)
b) If topic titles contains major spelling errors. I noticed this while helping to get 50% of the translations to Esperanto done. If you want to attract them to a page you should be able to fix crappy pages (here the diskusions / talk titles).
May by that LT will find a solution in order to handle such situations

11brightcopy
Mar 27, 2012, 9:28 am

#10 by @gangleri> Yes, there are good reasons to change the topic after 10 minutes. However, the decision was made that the bad reasons outweigh the good reasons. This was intentional and I don't really see how you could have a solution that doesn't let those bad situations happen. In all those cases, you can always create a new thread if the title is that important to you.

12jjwilson61
Mar 28, 2012, 10:12 am

Yet the same bad reasons exist for not changing Talk posts yet Tim lets us do that. Perhaps he should let us edit Talk subjects at any time but put an "edited" next to it if you do.

13brightcopy
Mar 28, 2012, 10:49 am

Yet you miss that there are more GOOD reasons for editing talk posts than subjects, thus more than offsetting the bad reasons. It's all a balance.

14jjwilson61
Mar 28, 2012, 4:34 pm

13> And those are? It seems to me that editing talk posts after a number of people have responded to it is a more pernicious problem then editing the subject.

15brightcopy
Mar 28, 2012, 4:46 pm

#14 by @jjwilson61> And those are?

I think if you'll stop and seriously consider for five minutes, you'll come up with a few big ones.

16AnnieMod
Mar 29, 2012, 12:55 am

It's a useful thing that we can edit after posting (with no restrictions in time and number of posts after that) but it can cause a lot of... problems. :) I use it a lot for keeping track of books and what's not (and fixing typos) but sometimes I wish people could not change posts that easy.

17gangleri
Mar 29, 2012, 4:39 pm