This topic is currently marked as "dormant"—the last message is more than 90 days old. You can revive it by posting a reply.
1r.orrison
Originally by Noisy:
The second 'editions' link (i.e. for the separated work) offered when a successful separation has been achieved offers a malformed link, with no '/' between the work number and 'editions', like this: http://www.librarything.com/work/9909564editions
Further identification by me:
Open two works that need to be combined in two tabs. On the tab with most editions listed, combine the two. On the other tab, click the Editions link.
Previous discussion here: http://www.librarything.com/topic/90658
The second 'editions' link (i.e. for the separated work) offered when a successful separation has been achieved offers a malformed link, with no '/' between the work number and 'editions', like this: http://www.librarything.com/work/9909564editions
Further identification by me:
Open two works that need to be combined in two tabs. On the tab with most editions listed, combine the two. On the other tab, click the Editions link.
Previous discussion here: http://www.librarything.com/topic/90658
2gangleri
another issue related to outdated links http://www.librarything.com/topic/99916
3timspalding
This was fixed at some point. Anyway, it's fixed now.
4r.orrison
No, it's not. I just opened works
711247
and
3680700
in two tabs in Firefox.
After combining them, from the 3680700 tab, I clicked the editions link on the 711247 tab, and got taken to:
http://www.librarything.com/work/711247editions
711247
and
3680700
in two tabs in Firefox.
After combining them, from the 3680700 tab, I clicked the editions link on the 711247 tab, and got taken to:
http://www.librarything.com/work/711247editions
5r.orrison
If you want to try it, open
http://www.librarything.com/combine.php?work=711247
in one tab, and
http://www.librarything.com/work/7639487
in another tab. From the first tab, combine the works. When that's done, click over to the second tab and click the Editions link.
http://www.librarything.com/combine.php?work=711247
in one tab, and
http://www.librarything.com/work/7639487
in another tab. From the first tab, combine the works. When that's done, click over to the second tab and click the Editions link.
6gangleri
http://www.librarything.com/topic/99925 refers here
7timspalding
Okay, what?
When I combine things, the page that comes up does not have any malformed links. Can anyone show me otherwise?
I don't understand but also don't really care what happens if you hold pages open, change the underlying data structure and then click from the pages.
When I combine things, the page that comes up does not have any malformed links. Can anyone show me otherwise?
I don't understand but also don't really care what happens if you hold pages open, change the underlying data structure and then click from the pages.
9brightcopy
7> It's not about holding pages open. It's about malformed links, as was reported. I know it's happened to me several times as well. I still haven't figured out exactly how to reproduce it, though I've tried.
Unfortunately, what r.orrison added in the second paragraph was that OTHER behavior. The first paragraph is all about the separation behavior.
8> This is a definite thing that happens you're talking about, but is not the same. I know exactly what you're talking about and that's not the one that causes a link like "http://www.librarything.com/work/9909564editions" (with the missing slash) to show up. This is a problem that happens during separations, not combining.
Again, r.orrison kind of confused thing with the second paragraph so I could see how you could get them conflated.
I'll keep trying to reproduce it, though. The frustrating part is that I just know it will happen, and undoing the separation and repeating the steps won't reproduce it.
Unfortunately, what r.orrison added in the second paragraph was that OTHER behavior. The first paragraph is all about the separation behavior.
8> This is a definite thing that happens you're talking about, but is not the same. I know exactly what you're talking about and that's not the one that causes a link like "http://www.librarything.com/work/9909564editions" (with the missing slash) to show up. This is a problem that happens during separations, not combining.
Again, r.orrison kind of confused thing with the second paragraph so I could see how you could get them conflated.
I'll keep trying to reproduce it, though. The frustrating part is that I just know it will happen, and undoing the separation and repeating the steps won't reproduce it.
10r.orrison
You haven't tried the example in message 5. There's nothing wrong with the links on the page that results from the combination, it depends on having two tabs open. Reiterating and expanding on message 5:
If you want to try it, open
http://www.librarything.com/combine.php?work=711247
in one tab, and
http://www.librarything.com/work/7639487
in another tab. From the first tab, combine the works. When that's done, the first tab containing the results of the combination is fine. The second tab still contains its original work 7639487, which is now combined into the first work, but HTML in the tab that's open doesn't know it. The editions link on that second tab will be
http://www.librarything.com/work/7639487/editions
but when you click it, the system tries to redirect you from that page to the editions page of the newly combined work, but gets it wrong, and you will end up at:
http://www.librarything.com/work/711247editions
Edit to add: It is important in this example to do the combination from 711247, which has more copies and will be the dominant work after the combination is complete. The error occurs on the tab that was open to the work with fewer copies, when, after combination, the system tries to redirect to the appropriate page of the newly dominant combined work and fails.
I don't know how to make it more clear. Try it with those two links open in two tabs.
If you want to try it, open
http://www.librarything.com/combine.php?work=711247
in one tab, and
http://www.librarything.com/work/7639487
in another tab. From the first tab, combine the works. When that's done, the first tab containing the results of the combination is fine. The second tab still contains its original work 7639487, which is now combined into the first work, but HTML in the tab that's open doesn't know it. The editions link on that second tab will be
http://www.librarything.com/work/7639487/editions
but when you click it, the system tries to redirect you from that page to the editions page of the newly combined work, but gets it wrong, and you will end up at:
http://www.librarything.com/work/711247editions
Edit to add: It is important in this example to do the combination from 711247, which has more copies and will be the dominant work after the combination is complete. The error occurs on the tab that was open to the work with fewer copies, when, after combination, the system tries to redirect to the appropriate page of the newly dominant combined work and fails.
I don't know how to make it more clear. Try it with those two links open in two tabs.
11timspalding
Okay, I'm still only just barely wrapping my head around this. But I think I fixed it.
12r.orrison
I've just tried it with a different pair of books, and it appeared to work. I haven't got time to try more, but it looks promising! (I've still left the examples in 5 and 10 for Tim.)
Confirmed with two more combinations.
Noisy, if you're reading this, can you test it using separations, like you initially reported it?
Confirmed with two more combinations.
Noisy, if you're reading this, can you test it using separations, like you initially reported it?
13brightcopy
Kudos to r.orrison for being able to describe that bug and kudos to Tim for being able to fix it. That has to be one of the most complicated bugs I've seen on LT - both to describe and to reproduce. I know it took me forever to fully understand exactly what you were talking about.
14DaynaRT
This bug has plagued me for so long. Will be sending my firstborn as thanks for its removal.
