broken links in "stats/series" when "/" is used in series name

TalkBug Collectors

Join LibraryThing to post.

broken links in "stats/series" when "/" is used in series name

This topic is currently marked as "dormant"—the last message is more than 90 days old. You can revive it by posting a reply.

1gangleri
Edited: Oct 8, 2010, 12:55 pm

reposting for "Bug Tracking" ( from http://www.librarything.com/topic/99306 ) because the bug is still present

examples: I am ashamed (about actual rendering) but you may look at the bottom of the fourth page at http://www.librarything.com/profile/gangleri/stats/series

There are still some series with "/" is used in series name.

Hope the bug will be fixed soon.

Regards Reinhardt

P.S. If you cklick on "סאוועטיש היימלאנד / Sovetish heymland" you get

http://www.librarything.com/series/%D7%A1%D7%90%D7%95%D7%95%D7%A2%D7%98%D7%99%D7...

"Sorry, but the page you requested can't be found. ..."

2lorax
Oct 8, 2010, 1:07 pm

To rule out one possible factor, this also occurs for pure-ASCII series names including a slash, so it's not the Hebrew or Cyrillic letters in gangleri's problematic series that are responsible.

From my own series page, the "Robots/Empire/Foundation - Chronological" series link resolves to:

http://www.librarything.com/series/Robot%2FEmpire%2FFoundation+-+Chronological

Manually entering the URL with slashes in place of the %2F characters produces a working page (which I cannot link to, because it will replace the slashes again.)

3brightcopy
Edited: Dec 4, 2010, 12:16 pm

Here's the JS from the Series page:

<a href="/series/%D7%A1%D7%90%D7%95
%D7%95%D7%A2%D7%98%D7%99%D7%A9+
%D7%94%D7%99%D7%99%D7%9E%D7%9C
%D7%90%D7%A0%D7%93+/+Sovetish+heymland">

And here it is from the stats page:

<a href="/series/%D7%A1%D7%90%D7%95%D7
%95%D7%A2%D7%98%D7%99%D7%A9+%D7
%94%D7%99%D7%99%D7%9E%D7%9C%D7%90
%D7%A0%D7%93+%2F+Sovetish+heymland">

The weird thing is that the only difference is the %2F instead of /. I'm not sure why that would make it go so bonkers.

ETA: lorax beat me to it (and provided confirmation). The slash getting changed to a %2F somehow really confuses it. Which doesn't make a lot of sense to me in terms of gangleri's example. I would think it's decoding those OTHER ones, so why shouldn't it decode the %2F?

4brightcopy
Oct 8, 2010, 1:11 pm

Ohhhhh... I get it. The slash is a special problem because the HTTP serving code is interpreting it as a path. Duh.

5gangleri
Edited: Oct 8, 2010, 1:15 pm

What I dis not mention is something I was puzzeled long time ago;

At http://www.librarything.com/work/book/53048331 the link to the series works fine.
Also at http://www.librarything.com/work/9192344/commonknowledge

I wondered why the LT SW code is / was that different.

fixed typos, minor rewording

P.S. I am not shure what other "stats/foo"" pages are affected.

6brightcopy
Oct 8, 2010, 1:15 pm

5> I have no idea what that means. Can you rephrase?

7gangleri
Oct 8, 2010, 1:25 pm

>2 lorax: It does not relate to Hebrew or Cyrillic letters . I have seen other such series at other users and LATIN character examples can still be found at my series.

btw: did you notice the "/dev/null" link on the first page.

It is a coincidence that I have a work there. I did not create that series.

8gangleri
Edited: Oct 8, 2010, 1:27 pm

>6 brightcopy:: at message 2 http://www.librarything.com/topic/99306#2216597 you may read:
jjmcgaffey:
Oh, lovely. Yes, here's another place where / and & are problematic. And I bet it applies to all of CK - awards, places, etc.

Hope the fix that worked in the catalog will work here!

9brightcopy
Oct 8, 2010, 1:29 pm

8> I still don't understand. On both of the pages you posted in #5, I can't find any links that are broken. They all properly take you to the series. What am I missing?

10gangleri
Oct 8, 2010, 1:34 pm

11lorax
Oct 8, 2010, 1:36 pm

7>

It does not relate to Hebrew or Cyrillic letters

Right, that's what I was saying. All the examples I saw in your library (except /dev/null, which I assumed was intentionally left blank, as a joke) did have non-ASCII characters, which is why I did the test, to present a minimal case.

5>

They work properly there because the slashes are not being converted into %2F. As I noted in my #2, if you manually type in the URL for any of your series using the slashes, you get to the correct page. (Sure, it's a path, but it just goes a couple layers deep into an otherwise empty directory structure, that's not a problem.) It's the conversion to %2F that's responsible for the problems, and that doesn't happen on the links from the works pages.

12Nicole_VanK
Edited: Oct 8, 2010, 1:38 pm

> 9: The series containing " / Sovetish heymland" (somehow the talk system seems to have a weird problem with the Hebrew characters, sorry) - bottom of gangleri's 4th series does display but doesn't lead anywhere if when you click it.

Is that the problem you're referring to gangleri?

13Nicole_VanK
Edited: Oct 8, 2010, 1:43 pm

> 11 (and 14 below): I think you're right about how the problem occurs. I remember it effected collection and tag titles too, by the way. (Personally I've replaced all slashes by pipes - which works like a charm).

14lorax
Edited: Oct 8, 2010, 1:42 pm

12>

The issue is this:

The link to the same series works in some places (the work page) and not in others (the statistics/series page). This is true for all series including a slash. The reason is that some places (the statistics/series page) converts the / to %2F, which doesn't resolve properly, and some places leave it in place, which leads to the page.

As I understand it, the issue is that the actual series page is not located at (gangleri, I'm going to use my example, since it avoids character set issues in the Talk posts getting ugly with quoting and editing), for instance, /series and named Robots%2FEmpire%2FFoundation (etc); it is located at /series/Robots/Empire/ and named Foundation (etc). So the escaped version can't find it.

eta: I see our posts crossed in the night. I'm leaving this up anyway in case anyone else is confused.

15jjmcgaffey
Edited: Oct 8, 2010, 1:44 pm

9> That the links actually work from those pages, but not from the series page - it's a counter-example, not another example of the bug. The catalog just recently got fixed (mostly*), the series page and probably other parts of CK are still struggling with certain characters.

The really weird thing is that it's accepting a slash as part of a series name no problem - but if the slash is encoded, it doesn't accept it (and tries to turn it into part of a path, as you said) and chokes.

*Related bug - which Tim says is several bugs and needs to be broken up (in a memo to self, he's not asking me/us to do it)
http://www.librarything.com/topic/99260

ETA post reference - lots of quick talking here!

16gangleri
Edited: Oct 8, 2010, 2:02 pm

Posts are comming very fast.

At the third of my series pages you may find
"Suizidologie / Suicidology"
The only issue is the SLAH.

at http://www.librarything.com/profile/gangleri/stats/characters
you may see a character "A / This is test topic/99305"

Conclusion: stats/characters, stats/places and stats/series are sharing LT SW code. The bug affects all three.

fixed html syntax

17gangleri
Oct 10, 2010, 5:28 pm

>7 gangleri: "btw: did you notice the "/dev/null" link on the first page."

It is mentioned in http://www.librarything.com/topic/99424#2241259 : One should change the CK and rename the series name to "AAAA - black hole LT error topic (whichever)"

18timspalding
Dec 4, 2010, 2:24 am

Okay, the series page one is fixed. I'm looking forward to hearing about other places, but I ask that the conversation be more focused and provide URLs.